Skip to content

Improve the error explanations for check_const #30932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2016
Merged

Improve the error explanations for check_const #30932

merged 1 commit into from
Jan 24, 2016

Conversation

@arielb1
Copy link
Contributor

@arielb1 arielb1 commented Jan 15, 2016

Fixes #30705

r? @nagisa

GuillaumeGomez
GuillaumeGomez reviewed Jan 15, 2016
View reviewed changes
src/librustc/diagnostics.rs Outdated
Copy link
Member

@GuillaumeGomez GuillaumeGomez Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"// ..and also"? Isn't "// ... and also" better?

@nagisa
Copy link
Member

nagisa commented Jan 15, 2016

Looks like an overall improvement.

@arielb1
Copy link
Contributor Author

arielb1 commented Jan 15, 2016

improved

mahkoh
mahkoh reviewed Jan 15, 2016
View reviewed changes
src/librustc/diagnostics.rs Outdated
Copy link
Contributor

@mahkoh mahkoh Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. This document already contains various cases of wrong advice.

Copy link
Contributor Author

@arielb1 arielb1 Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong?

Copy link
Contributor

@mahkoh mahkoh Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the problem is that you need the value behind a pointer in a static variable, then not putting the value in a static variable does not fix the problem.

Copy link
Contributor Author

@arielb1 arielb1 Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not like you can solve the problem.

Copy link
Contributor Author

@arielb1 arielb1 Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how important is the "how to fix this" advice, because each issue will have its own fix.

nagisa
nagisa reviewed Jan 15, 2016
View reviewed changes
src/librustc/diagnostics.rs Outdated
Copy link
Member

@nagisa nagisa Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This paragraph should use inline code for the constant names.

@nagisa
Copy link
Member

nagisa commented Jan 15, 2016

r=me once the two nits are fixed.

@arielb1
Copy link
Contributor Author

arielb1 commented Jan 19, 2016

fixed ^

@nagisa
Copy link
Member

nagisa commented Jan 19, 2016

@bors r+ cad3882

@nagisa
Copy link
Member

nagisa commented Jan 19, 2016

@bors rollup

@bors
Copy link
Collaborator

bors commented Jan 21, 2016

☔ The latest upstream changes (presumably #31024) made this pull request unmergeable. Please resolve the merge conflicts.

This was referenced Jan 23, 2016
Closed
Merged
bors added a commit that referenced this pull request Jan 23, 2016
@bors
Auto merge of #31148 - steveklabnik:rollup, r=steveklabnik
0486e12 
- Successful merges: #30997, #31019, #31031, #31035, #31045, #31050, #31054, #31055, #31061, #31088, #31090, #31111, #31113, #31128, #31130, #31136, #31145, #31146
- Failed merges: #30932
@bors
Copy link
Collaborator

bors commented Jan 23, 2016

🔒 Merge conflict

@arielb1
Copy link
Contributor Author

arielb1 commented Jan 24, 2016

@bors r=nagisa rollup

@bors
Copy link
Collaborator

bors commented Jan 24, 2016

📌 Commit 47593da has been approved by nagisa

@bors
Copy link
Collaborator

bors commented Jan 24, 2016

⌛ Testing commit 47593da with merge 5a81d9a...

bors added a commit that referenced this pull request Jan 24, 2016
@bors
Auto merge of #30932 - arielb1:raw-const-errors, r=nagisa
5a81d9a 
Fixes #30705

r? @nagisa
@bors
Copy link
Collaborator

bors commented Jan 24, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 47593da into rust-lang:master Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nagisa nagisa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arielb1 @nagisa @bors @oli-obk @mahkoh @GuillaumeGomez